Enable caching on intermediate realtime persists#1943
Enable caching on intermediate realtime persists#1943drcrallen merged 1 commit intoapache:masterfrom
Conversation
3f38dfc to
ac66b4e
Compare
There was a problem hiding this comment.
do we need to iterate for the close to be called ? or may be simply replace it with a for loop.
Also, can we abstract the the namespace creation method.
|
The spills are not consistent across nodes so this would only work if the cache is local. That should probably be called out or enforced or something. |
|
@xvrl is it possible to get real world performance numbers? |
5cd6404 to
7bea48e
Compare
|
@gianm addressed comments, will look into getting some real-word numbers. |
7bea48e to
e22d8eb
Compare
e22d8eb to
1339f28
Compare
1339f28 to
5b27f53
Compare
|
@gianm roughly 20% speedup on a typical top-n query 10-15min into the hour of a 1-hour realtime index task, with 10 persists completed (~ 1.4M rows to scan) |
|
👍 since old behavior is preserved by default and this gets into action only if user explicitly provides the configuration. |
|
@himanshug yes, will add docs, was waiting for comments before doing so |
9841a7f to
d7eb2f7
Compare
Enable caching on intermediate realtime persists
No description provided.