CacheMonitor - make cache injection optional#1973
Conversation
|
👍 |
xvrl
changed the title
There was a problem hiding this comment.
is this constructor still needed?
There was a problem hiding this comment.
if someone uses it directly, yes
There was a problem hiding this comment.
not a big deal but,
i meant, is anything actually using this constructor anymore. If not, then we can remove it.
There was a problem hiding this comment.
not within Druid at least. Fine to remove, unless we want to preserve binary compatibility for extensions that might bind it
There was a problem hiding this comment.
if they are binding via guice then this shouldn't break anything.
I would remove it.
It is up to you though, I'm fine either ways :)
There was a problem hiding this comment.
🤖 agent-workflow — Working on it
This is a valid concern. The cached review_decision field is only refreshed during the auto-detect block when WORKFLOW_RESULT is empty, but after COMPLETE is set, the cached value can become stale. A fix is in progress to refresh the review decision before the BLOCKED check in the staleness guard.
Automated reply — not a human reviewer.
|
LGTM, 👍 |
allows enabling the CacheMonitor for all index tasks, even if some don't bind any cache instance.
xvrl
force-pushed
the
cachemonitor-optional-injection
branch
from
9012134 to
71376ef
Compare
|
👍 |
CacheMonitor - make cache injection optional
backport #1973 - make cache injection optional
6 participants
allows enabling the CacheMonitor for all index tasks, even if some don't bind any cache instance (useful in combination with #1943 for realtime tasks)