add numRows to segment metadata query response#1995
Merged
jon-wei merged 1 commit intoapache:masterfrom Dec 17, 2015
Merged
Conversation
himanshug
force-pushed
the
num_rows_seg_metadata_query
branch
from
9960e6e to
7a89b2e
Compare
Contributor
|
@himanshug do you think we should add an analysis type for numRows, or simply always report it? I guess always reporting is fine, as numRows is cheap to compute- I think it's cached in the java heap and doesn't require hitting the mmapped segment. |
Contributor
|
👍 |
Contributor
Author
|
@gianm numRows is already available in the code so no expense . |
Contributor
|
👍 |
jon-wei
added a commit
that referenced
this pull request
Dec 17, 2015
add numRows to segment metadata query response
himanshug
pushed a commit
to himanshug/druid
that referenced
this pull request
Jan 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often need to see the number of rows in segments for some intervals. currently you can do that, for example, by sending a group-by query with count aggregator.
however, I think adding numRows to segment metadata query response makes it way more convenient.
also other queries with count aggregator would need to scan the segment in order to compute rows in the segment.