More efficient SegmentMetadataQuery#2107
Merged
fjy merged 1 commit intoapache:masterfrom Dec 19, 2015
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
@Nullable is not valid probably. I think IDE is adding it automatically ?
Contributor
Author
There was a problem hiding this comment.
@himanshug Hm, yes, it was added by IDE since it was part of the Function interface definition. I've removed the @nullables.
Contributor
|
👍 |
Contributor
Author
|
@himanshug Merged your other PR, resolving conflicts |
Contributor
Contributor
Author
|
@himanshug This one's fine in that respect, the result output won't change since the query uses default analysis types |
Contributor
|
👍 |
fjy
added a commit
that referenced
this pull request
Dec 19, 2015
More efficient SegmentMetadataQuery
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #2081
This PR makes 3 changes:
Running with a 3,450 segment test set on my laptop, the SegmentMetadataQuery takes ~16s to complete without the patch, and ~70ms with the new interval condensing behavior.