Skip to content

Use default service names in examples.#2048

Closed
nishantmonu51 wants to merge 1 commit intoapache:masterfrom
metamx:fix-servicename
Closed

Use default service names in examples.#2048
nishantmonu51 wants to merge 1 commit intoapache:masterfrom
metamx:fix-servicename

Conversation

@nishantmonu51
Copy link
Copy Markdown
Member

Use default service names in druid examples.
Make them consistent with service names in druid code.
fixes #2046

@himanshug
Copy link
Copy Markdown
Contributor

👍

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Dec 6, 2015

@nishantmonu51 if you change things here, make sure tranquility still works by default

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is not right

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Dec 6, 2015

Oops, I did #2052 before seeing this PR. I am biased toward that one though. It updates a few more things and also fixes the router docs.

@nishantmonu51
Copy link
Copy Markdown
Member Author

closing in favor of #2052

seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default service names in examples, druid-code and tranquility should match

4 participants