Change service names in docs, examples to match defaults in the code.#2052
Merged
fjy merged 1 commit intoapache:masterfrom Dec 8, 2015
Merged
Change service names in docs, examples to match defaults in the code.#2052fjy merged 1 commit intoapache:masterfrom
fjy merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
fixes #2046 |
gianm
force-pushed
the
service-names
branch
2 times, most recently
from
d2dc70c to
889d28c
Compare
Member
There was a problem hiding this comment.
this can be commented by default.
Contributor
Author
There was a problem hiding this comment.
also changed to "druid/overlord" to match code
Contributor
|
👍, minor comment: can we document what the default names and ports are somewhere? E.g. common configuration? |
fjy
added a commit
that referenced
this pull request
Dec 8, 2015
Change service names in docs, examples to match defaults in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the "production config" docs, the config examples, and the code all have different defaults for service names. This makes it hard to choose the best default in tranquility or for any other program that interacts with Druid through service discovery.
This patch changes them all to "druid/foo".
Also removes the "If you run each node type on its own node in production, you should override these values to be IP:8080" advice as that is not actually necessary.