PropertiesModule: Print properties, processors, totalMemory on startup.#2452
PropertiesModule: Print properties, processors, totalMemory on startup.#2452himanshug merged 1 commit intoapache:masterfrom
Conversation
|
👍 |
PropertiesModule: Print properties, processors, totalMemory on startup.
|
@gianm can we backport this? |
| ); | ||
|
|
||
| for (String propertyName : Ordering.natural().sortedCopy(props.stringPropertyNames())) { | ||
| log.info("* %s: %s", propertyName, props.getProperty(propertyName)); |
There was a problem hiding this comment.
this will print aws credentials in log, please remove.
There was a problem hiding this comment.
IMHO printing out the property names should be fine, but we should not print out property values unless we have a way to differentiate secure from insecure properties.
There was a problem hiding this comment.
you don't have to put your properties there, there are ways to read these credentials from file
There was a problem hiding this comment.
Then we should remove support for the way that puts plain text credentials into the log by default.
There was a problem hiding this comment.
druid does not provide any default way to supply the db credentials other than passing them in properties file.
|
@gianm acceptable alternatives would make this configurable as opt-in, or simply printing out the keys but not the values. |
|
+1, on making it configurable. |
|
@gianm I'd be ok with making the setting to enable it have it set equal to TRUE in the template runtime.properties that get packaged by default, but in the absence of a setting printing of the value of properties should be disabled. |
|
@drcrallen sounds good, will do another PR. |
Off by default, but enabled in the example config files. See also apache#2452.
Off by default, but enabled in the example config files. See also apache#2452.
Off by default, but enabled in the example config files. See also apache#2452.
5 participants
Should help with debugging issues from the mailing lists.