Skip to content

PropertiesModule: Print properties, processors, totalMemory on startup. #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himanshug merged 1 commit into from
Feb 11, 2016
Merged

PropertiesModule: Print properties, processors, totalMemory on startup. #2452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions processing/src/main/java/io/druid/guice/PropertiesModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import com.google.common.base.Charsets;
import com.google.common.base.Throwables;
import com.google.common.collect.Ordering;
import com.google.inject.Binder;
import com.google.inject.Module;
import com.metamx.common.guava.CloseQuietly;
Expand Down Expand Up @@ -86,6 +87,16 @@ public void configure(Binder binder)
}
}

log.info(
"Loaded properties into JVM with processors[%,d], memory[%,d].",
Runtime.getRuntime().availableProcessors(),
Runtime.getRuntime().totalMemory()
);

for (String propertyName : Ordering.natural().sortedCopy(props.stringPropertyNames())) {
log.info("* %s: %s", propertyName, props.getProperty(propertyName));
Copy link
Copy Markdown
Contributor

@drcrallen drcrallen Feb 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will print aws credentials in log, please remove.

Copy link
Copy Markdown
Contributor

@drcrallen drcrallen Feb 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with db user pass

Copy link
Copy Markdown
Contributor

@drcrallen drcrallen Feb 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO printing out the property names should be fine, but we should not print out property values unless we have a way to differentiate secure from insecure properties.

Copy link
Copy Markdown
Contributor

@fjy fjy Feb 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't have to put your properties there, there are ways to read these credentials from file

Copy link
Copy Markdown
Contributor

@drcrallen drcrallen Feb 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should remove support for the way that puts plain text credentials into the log by default.

Copy link
Copy Markdown
Member

@nishantmonu51 nishantmonu51 Feb 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

druid does not provide any default way to supply the db credentials other than passing them in properties file.

}

binder.bind(Properties.class).toInstance(props);
}
}