Skip to content

log exception correctly in DatasourceInputFormat and IndexGeneratorJob #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guobingkun merged 1 commit into from
Mar 9, 2016
Merged

log exception correctly in DatasourceInputFormat and IndexGeneratorJob #2620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion indexing-hadoop/src/main/java/io/druid/indexer/IndexGeneratorJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ public void doRun()
persist(persistIndex, interval, file, progressIndicator);
}
catch (Exception e) {
log.error("persist index error", e);
log.error(e, "persist index error");
throw Throwables.propagate(e);
}
finally {
Expand Down
8 changes: 5 additions & 3 deletions indexing-hadoop/src/main/java/io/druid/indexer/hadoop/DatasourceInputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ public org.apache.hadoop.mapred.InputFormat get()
};

@VisibleForTesting
DatasourceInputFormat setSupplier(Supplier<org.apache.hadoop.mapred.InputFormat> supplier) {
DatasourceInputFormat setSupplier(Supplier<org.apache.hadoop.mapred.InputFormat> supplier)
{
this.supplier = supplier;
return this;
}
Expand All @@ -160,7 +161,7 @@ private DatasourceInputSplit toDataSourceSplit(
locations = getFrequentLocations(segments, fio, conf);
}
catch (Exception e) {
logger.error("Exception thrown finding location of splits", e);
logger.error(e, "Exception thrown finding location of splits");
}
return new DatasourceInputSplit(segments, locations);
}
Expand All @@ -181,7 +182,8 @@ private String[] getFrequentLocations(
return getFrequentLocations(locations);
}

private static String[] getFrequentLocations(Iterable<String> hosts) {
private static String[] getFrequentLocations(Iterable<String> hosts)
{

final CountingMap<String> counter = new CountingMap<>();
for (String location : hosts) {
Expand Down