log exception correctly in DatasourceInputFormat and IndexGeneratorJob#2620
Merged
guobingkun merged 1 commit intoapache:masterfrom Mar 9, 2016
Merged
log exception correctly in DatasourceInputFormat and IndexGeneratorJob#2620guobingkun merged 1 commit intoapache:masterfrom
guobingkun merged 1 commit intoapache:masterfrom
Conversation
guobingkun
force-pushed
the
fix_log
branch
2 times, most recently
from
492f90c to
36c7411
Compare
Contributor
There was a problem hiding this comment.
i don't this needs to be propagated. finding locations should only be best effort.
guobingkun
changed the title
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Contributor
|
I filed metamx/java-util#44 to hopefully make this less of an issue sometime in the future |
guobingkun
pushed a commit
that referenced
this pull request
Mar 9, 2016
log exception correctly in DatasourceInputFormat and IndexGeneratorJob
seoeun25
added a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions in IndexGeneratorJob and DatasourceInputFormat were logged properly.