Add @Deprecated catch for logging assuming slf4j convention#44
Merged
Add @Deprecated catch for logging assuming slf4j convention#44
Conversation
| final Throwable throwable = new Throwable(); | ||
| log.error("foo", throwable); | ||
| log.warn("foo", throwable); | ||
| } |
Contributor
There was a problem hiding this comment.
i think you are expecting IDE to flag these as deprecated. but since there are no asserts, its difficult for someone to understand what is being "tested" here. can you add comment telling why this test needs to exist or may be remove it since it can't really "fail" whether or not the thing you expected works or not.
Contributor
|
👍 |
drcrallen
force-pushed
the
saferLoggingOfCriticalErrors
branch
from
998a13b to
b80faf4
Compare
Contributor
Author
|
@himanshug any other comments? |
Contributor
|
+1. Don't see a better way to protect from this or exclude this situation. |
Contributor
|
However seems that it uses inconsistent formatting.. { no the same line. |
This was referenced Sep 21, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very easy for people unfamiliar with the logging conventions used here to swap these arguments, sometimes not yielding the desired information. This PR shows that methodology as deprecated and hopefully helps track down erroneous logging usages.
This might potentially change logging if someone had done the following:
LOG.error("found an error: %s", someException);The fix would be to do something like
LOG.error("found an error: %s", someException.getMessage());