Skip to content

refactor extensions into their own docs#2698

Merged
fjy merged 1 commit intomasterfrom
fix-ext-docs
Mar 23, 2016
Merged

refactor extensions into their own docs#2698
fjy merged 1 commit intomasterfrom
fix-ext-docs

Conversation

@fjy
Copy link
Copy Markdown
Contributor

@fjy fjy commented Mar 22, 2016

No description provided.

@fjy fjy added this to the 0.9.0 milestone Mar 22, 2016
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be good to leave the header but then in the body of this section, deep link to the relevant extension doc. That way it's clear that we support HDFS/S3 and there are not too many clicks needed to get there.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment for MD stores

@jon-wei
Copy link
Copy Markdown
Contributor

jon-wei commented Mar 22, 2016

👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"See the [druid-s3-extensions extension documentation]." would read better than "See [here]."

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Mar 22, 2016

this change was discussed during the dev sync on 2016-03-22 as a way of clarifying which configs are from extensions and which configs are not.

👍

@fjy fjy closed this Mar 23, 2016
@fjy fjy reopened this Mar 23, 2016
@fjy fjy closed this Mar 23, 2016
@fjy fjy reopened this Mar 23, 2016
@fjy fjy closed this Mar 23, 2016
@fjy fjy reopened this Mar 23, 2016
@fjy fjy closed this Mar 23, 2016
@fjy fjy reopened this Mar 23, 2016
@fjy fjy merged commit d1f8f2b into master Mar 23, 2016
@fjy fjy deleted the fix-ext-docs branch March 23, 2016 05:04
@drcrallen
Copy link
Copy Markdown
Contributor

this change moved some lookup docs into the wrong directory.

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Mar 25, 2016

@drcrallen which ones? Will you be opening up a PR to fix that or should @fjy look into it?

@drcrallen
Copy link
Copy Markdown
Contributor

Dynamic Config is not an extension as it does not actually DO anything, but rather just provides a framework for getting the config around. There's the part that's in druid as of 0.9.1 #2735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants