Move lookup docs that are in druid-proper back into lookups.md#2735
Move lookup docs that are in druid-proper back into lookups.md#2735fjy merged 1 commit intoapache:masterfrom
Conversation
|
@drcrallen Is dynamic configuration not a part of any extension? |
There was a problem hiding this comment.
can we use the note-caution div to indicate experimental?
There was a problem hiding this comment.
I can, but don't know the syntax you're looking for, is there another doc that uses that indication?
|
@drcrallen this will have to be backported |
|
Dynamic config is not an extension |
0193b33 to
92c1f35
Compare
|
@fjy well, this feature is in 0.9.1 not 0.9.0 |
|
@drcrallen okay can we remove it from the 0.9.0 docs then? |
|
they are not in 0.9.0: https://github.com/druid-io/druid/blob/0.9.0/docs/content/querying/lookups.md |
92c1f35 to
82c4ad2
Compare
|
@drcrallen is the namespaced lookup extension no longer suggested for use in 0.9.1, in favor of the dynamic config stuff? |
|
ok, I'm asking because this PR removes references to the namespaced-lookups extension from lookups.md. I feel like we should have some stuff on both lookups.md and the namespaced lookup extension docs that clarify the situation for readers. |
|
@drcrallen In other words: I am happy with this PR to the degree that you are happy with how lookups.md and namespaced-lookup.md make it clear to readers what the options are for cluster-wide server-side query time lookups, and what the most recommended option is. |
|
@gianm ah good point, I read
and thought of the cluster wide config. I didn't think of the static config in the extension. I'll add that line back in. |
82c4ad2 to
ab324e4
Compare
|
@gianm changed to
|
|
👍 looks good to me, thanks for catching this. |
No description provided.