how to query in the querying section, correct default for select strategy, formatting#2702
Merged
gianm merged 1 commit intoapache:masterfrom Mar 22, 2016
pjain1:improve_docs
Merged
how to query in the querying section, correct default for select strategy, formatting#2702gianm merged 1 commit intoapache:masterfrom pjain1:improve_docs
gianm merged 1 commit intoapache:masterfrom
pjain1:improve_docs
Conversation
Contributor
There was a problem hiding this comment.
hmm this seems very odd when placed under the "javascript" strategy. The default "type" for a javascript select strategy is "fillCapacity"?
IMO wording like "required; must be javascript" would make more sense.
Member
Author
There was a problem hiding this comment.
I see what you are saying, let me make that change
Contributor
|
👍 |
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.