make Coordinator IndexingService helpers pluggable#2712
Merged
pjain1 merged 1 commit intoapache:masterfrom Mar 28, 2016
Merged
Conversation
Contributor
There was a problem hiding this comment.
by default what is this value?
Contributor
Author
There was a problem hiding this comment.
by default it is "false", it was set here
Contributor
There was a problem hiding this comment.
i think we should maybe change this default ot true.
Contributor
There was a problem hiding this comment.
Change of default value is outside of scope for this PR.
guobingkun
force-pushed
the
make_runnables_pluggable
branch
from
e217a21 to
228586a
Compare
Member
|
👍 apart from https://github.com/druid-io/druid/pull/2712/files#r57381845 and after travis |
Contributor
|
👍 after dependency is in and travis passes. |
guobingkun
force-pushed
the
make_runnables_pluggable
branch
from
228586a to
1f1ea48
Compare
Fixes apache#2682 IndexingService helpers are added according to the settings in runtime.properties. Rather than having all the config.isXXX checks there, it makes sense to have a pluggable approach for allowing the dynamic configuration to bring in implementations for helpers without having to have hard-coded sets of available helpers. Plus, it will also make it possible for extensions to plug helpers in. With druid-io/druid-api#76, we could conditionally bind a helper to Coordinator's runlist. The condition is driven by the value set in the runtime.properties.
guobingkun
force-pushed
the
make_runnables_pluggable
branch
from
1f1ea48 to
0872448
Compare
Contributor
Author
|
@pjain1 @drcrallen Done rebasing. |
guobingkun
pushed a commit
to guobingkun/druid
that referenced
this pull request
Mar 30, 2016
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2682
Depends on #2724
IndexingService helpers are added according to the settings in runtime.properties.
Rather than having all the config.isXXX checks there, it makes sense to have a pluggable
approach for allowing the dynamic configuration to bring in implementations for helpers
without having to have hard-coded sets of available helpers. Plus, it will also make it possible for extensions to plug helpers in.
With druid-io/druid-api#76, we could conditionally bind a helper to Coordinator's runlist.
The condition is driven by the value set in the runtime.properties.