Add ability to skip loadSpec,dimensions, metrics from DataSegment Announcements#2784
Conversation
|
👍 |
There was a problem hiding this comment.
these wil need to be documented
|
👍 after docs are added |
There was a problem hiding this comment.
do we need separate configs for dimensions and metrics? Is there any use in having one but not the other?
There was a problem hiding this comment.
added separate config in case someone has any tools built on top which needs metrics list and not dimensions list or vice versa.
There was a problem hiding this comment.
does it actually make sense to have one but not the other?
|
@nishantmonu51 conflicts |
separate config for each skipping dimensions, metrics and loadSpec Add test fix test comment Add docs
nishantmonu51
force-pushed
the
lite-segment-announcements
branch
from
16c3fe1 to
edd74f2
Compare
|
@fjy: resolved conflicts and added docs. |
|
@b-slim I still had some comments outstanding on this one, it would have been nice to wait for my +1 |
|
@xvrl sorry I haven't seen that. |
|
|
|
After setting druid.announcer.skipDimensionsAndMetrics to true, metric information and dimension information in coordinator page will disappeared ,it seems not friendly for users. |
5 participants
This can be useful in order to reduce the heap pressure on the coordinator and broker when the number of DataSegments to be tracked are huge.
Note: Broker/coordinator end points that expose list of dimensions & metrics will report empty set of dimensions and metrics if skipDimensions and skipMetrics are set to true. However this info can still be queried using SegmentMetadataQuery.