Skip to content

handle review comments for PR 2784#2821

Merged
fjy merged 1 commit intoapache:masterfrom
metamx:review-comments-2784
Apr 12, 2016
Merged

handle review comments for PR 2784#2821
fjy merged 1 commit intoapache:masterfrom
metamx:review-comments-2784

Conversation

@nishantmonu51
Copy link
Copy Markdown
Member

follow up PR for review comment -
#2784 (comment)

@xvrl
Copy link
Copy Markdown
Member

xvrl commented Apr 12, 2016

👍

@xvrl xvrl added this to the 0.9.1 milestone Apr 12, 2016
|`druid.announcer.maxBytesPerNode`|Max byte size for Znode.|524288|
|`druid.announcer.skipDimensions`|Skip Dimension list from segment announcements. NOTE: Enabling this will also remove the dimensions list from coordinator and broker endpoints.|false|
|`druid.announcer.skipMetrics`|Skip Metrics list from segment announcements. NOTE: Enabling this will also remove the metrics list from coordinator and broker endpoints.|false|
|`druid.announcer.skipDimensionsAndMetrics`|Skip Dimensions and Metrics list from segment announcements. NOTE: Enabling this will also remove the dimensions and metrics list from coordinator and broker endpoints.|false|
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still have this info available via segment metadata query?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjy this PR is not changing anything, #2784 is the one that made the changes, and you +1 that one.

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Apr 12, 2016

👍

@fjy fjy merged commit 886ee4e into apache:master Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants