Intern ServerInventoryView inventory objects.#3238
Merged
nishantmonu51 merged 1 commit intoapache:masterfrom Jul 14, 2016
Merged
Intern ServerInventoryView inventory objects.#3238nishantmonu51 merged 1 commit intoapache:masterfrom
nishantmonu51 merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
I'm working on getting this rolled out internally |
drcrallen
force-pushed
the
internInventory
branch
from
a6cb564 to
cc4909a
Compare
Contributor
Author
|
Results are promising so far. With this patch tending to lead to ~50% reduction in old-gen (java heap%) size as time progresses. Orange is this patch, Blue is a node without this patch. Both were restarted at nearly the same time (as close as rolling-restarts can get you) |
drcrallen
changed the title
Contributor
|
Per #3237 (comment) it seems fair to do this in order to de-dupe replicas of the same segment regardless of what happens for #3237. For #3237 IMO this shouldn't be considered a fix, we should actually collapse the two server views into one. |
Contributor
Author
|
@gianm agreed on not a fix. I'm hoping "Related" doesn't count as "Fixed" in github-land-auto-closing |
Contributor
|
👍 |
Member
|
👍 |
drcrallen
added a commit
to metamx/druid
that referenced
this pull request
Jul 19, 2016
drcrallen
added a commit
to metamx/druid
that referenced
this pull request
Jul 26, 2016
…che#3238)" This reverts commit a931deb. Fixes apache#3283 The core issue here is that realtime nodes announce their size as 0, so a coordinator which interns the realtime version of the data segment will not be able to see the new sized announcement when handoff occurs. This is caused by the `eauals` method on a `DataSegment` only evaluating the identifier. the `eauals` method *should* be correct for object equivalence, and things which need to check equivalence of some sub-portion of the object should do so explicitly.
drcrallen
added a commit
to metamx/druid
that referenced
this pull request
Jul 26, 2016
…che#3238)" This reverts commit a931deb. Fixes apache#3283 The core issue here is that realtime nodes announce their size as 0, so a coordinator which interns the realtime version of the data segment will not be able to see the new sized announcement when handoff occurs. This is caused by the `eauals` method on a `DataSegment` only evaluating the identifier. the `eauals` method *should* be correct for object equivalence, and things which need to check equivalence of some sub-portion of the object should do so explicitly.
fjy
pushed a commit
that referenced
this pull request
Jul 26, 2016
…)" (#3286) This reverts commit a931deb. Fixes #3283 The core issue here is that realtime nodes announce their size as 0, so a coordinator which interns the realtime version of the data segment will not be able to see the new sized announcement when handoff occurs. This is caused by the `eauals` method on a `DataSegment` only evaluating the identifier. the `eauals` method *should* be correct for object equivalence, and things which need to check equivalence of some sub-portion of the object should do so explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows replicants of data segments to only take up one chunklet of heap in the server view.
Related to #3237