Merged
Conversation
cheddar
reviewed
Nov 9, 2016
| private final GatheringByteChannel channel = out.getChannel();; | ||
| private final GatheringByteChannel channel = out.getChannel(); | ||
| private final Closer closer = Closer.create(); | ||
| ; |
Contributor
There was a problem hiding this comment.
What is this semicolon doing?
| if (!completedFiles.isEmpty() || !filesInProcess.isEmpty()) { | ||
| for (File file : completedFiles) { | ||
| if (!file.delete()) { | ||
| LOG.warn("Unable to delete file [%s]", file.getPath()); |
Contributor
There was a problem hiding this comment.
I think just passing file is enough instead of file.getPath()
| } | ||
| } | ||
| throw new ISE(String.format("%d writers needs to be closed before closing smoosher.", filesInProcess.size() + completedFiles.size())); | ||
| throw new ISE(String.format( |
Contributor
There was a problem hiding this comment.
ISE does a String.format for you, don't need to duplicate it here. Also, the message is probably a lot nicer if you expose both numbers instead of only exposing the sum.
Contributor
Author
|
@cheddar @drcrallen Thanks for reviewing this PR, uploaded a new patch set to address code review comments. |
Contributor
|
👍 |
Contributor
|
👍 |
fundead
pushed a commit
to fundead/druid
that referenced
this pull request
Dec 7, 2016
* FileSmoosher requested changes from metamx/java-util#55 * Addressed code review requested changes.
dgolitsyn
pushed a commit
to metamx/druid
that referenced
this pull request
Feb 14, 2017
* FileSmoosher requested changes from metamx/java-util#55 * Addressed code review requested changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3640 and metamx/java-util#55 requested changes.