assume http if scheme is null#4912
Merged
pjain1 merged 1 commit intoapache:masterfrom Oct 6, 2017
pjain1:fix_log_stream
Merged
assume http if scheme is null#4912pjain1 merged 1 commit intoapache:masterfrom pjain1:fix_log_stream
pjain1 merged 1 commit intoapache:masterfrom
pjain1:fix_log_stream
Conversation
himanshug
reviewed
Oct 6, 2017
Contributor
There was a problem hiding this comment.
can you update Worker class instead to handle null scheme in constructor so that its covered for all the places worker.getScheme() would have been used?
Contributor
There was a problem hiding this comment.
I think handling it in the Worker class makes sense too.
Also that would fix other usages of worker.getScheme() that don't have null checks (looks like there is 1 other).
gianm
approved these changes
Oct 6, 2017
Contributor
There was a problem hiding this comment.
Add a comment that this is needed for backwards compatibility with older workers (pre-#4270) and I think this is good to go.
Contributor
|
👍 |
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Oct 6, 2017
jon-wei
pushed a commit
that referenced
this pull request
Oct 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4910