Use ubuntu image with pre-installed java 8 for IT docker#4970
Use ubuntu image with pre-installed java 8 for IT docker#4970leventov merged 8 commits intoapache:masterfrom
Conversation
3199913 to
55ea163
Compare
|
integration tests are able to run with this patch now, but the latest run hit travis' job time limit |
|
Travis CI passes with this, if we're still having problems tomorrow with the integration tests related to the java 8 install, this will fix the issues for now. |
| && apt-get install -y oracle-java8-installer \ | ||
| && apt-get install -y oracle-java8-set-default \ | ||
| && rm -rf /var/cache/oracle-jdk8-installer | ||
| FROM jonweiimply/ubuntu-j8 |
There was a problem hiding this comment.
This line certainly needs some comments, ideally describing the image, linking to the Dockerfile that produced the image, and linking to this issue. It should also be temporary; even if we want to use our own Docker base image long term, it should be something in an organization repo rather than a personal repo.
There was a problem hiding this comment.
Added a comment on the temporary nature of the change and a link to the dockerhub page for the image, which has a description of the commands used to build it
* Use OpenJDK8 instead of Oracle for IT docker * install wget * Use different docker image * Revert "Use different docker image" This reverts commit 5786c03. * Revert "install wget" This reverts commit 8d1d5ec. * Revert "Use OpenJDK8 instead of Oracle for IT docker" This reverts commit 55ea163. * Use prebuilt java8 image * Add comment on docker image
* Use OpenJDK8 instead of Oracle for IT docker * install wget * Use different docker image * Revert "Use different docker image" This reverts commit 5786c03. * Revert "install wget" This reverts commit 8d1d5ec. * Revert "Use OpenJDK8 instead of Oracle for IT docker" This reverts commit 55ea163. * Use prebuilt java8 image * Add comment on docker image
* Use OpenJDK8 instead of Oracle for IT docker * install wget * Use different docker image * Revert "Use different docker image" This reverts commit 5786c03. * Revert "install wget" This reverts commit 8d1d5ec. * Revert "Use OpenJDK8 instead of Oracle for IT docker" This reverts commit 55ea163. * Use prebuilt java8 image * Add comment on docker image
|
Can you explain more why an openjdk build does not suffice for integration tests? I'm a bit worried about using something based on |
|
@drcrallen When I last tried using OpenJDK instead of Oracle, the integration tests never completed, individual tests seemed to take up to 50% longer if I remember correctly, not sure why there was such slowdown |
|
Gotcha, thanks. This is helpful for any future questions or discussions on the matter. |
|
Be careful when using public, prebuilt Docker images with Oracle Java inside. It is not clear if it doesn't violate their convoluted licensing. Just saying, IANAL. |
The integration tests in Travis CI are failing because the docker image can't be built:
The patch changes the integration test docker container to build from an ubuntu 14.04 image with these commands already completed:
This is intended to be a temporary change, please refer to the comment in the PR change.
https://hub.docker.com/r/jonweiimply/ubuntu-j8/