IT: Switch to OpenJDK8 base image.#5060
Conversation
Also split the Docker image into a base image and a child image, and build the base image ahead of time for efficiency's sake. Also upgrade ZK to 3.4.10.
|
OpenJDK was attempted in #4970 but the tests didn't pass: #4970 (comment). So let's see if it works today. Maybe installing more things on the image ahead of time would help. |
|
ITs passed in 34 minutes: https://travis-ci.org/druid-io/druid/jobs/299375692. I think the max is 50 so it seems like a good enough margin of error. |
|
Could you please add a comment in |
|
Adding to |
| /root/.m2 | ||
|
|
||
| # Base image is built from integration-tests/docker-base in the Druid repo | ||
| FROM imply/druiditbase |
There was a problem hiding this comment.
It would be nice to eventually pull from a druid-io source, ECR, GCR, Docker Hub, and Quay are all options. Is there any pro or con to any of them that folks know about?
There was a problem hiding this comment.
Docker Hub is built into docker so that's a pro in favor of that one. It's also free. It's pretty bare bones but should be good enough for what we're doing.
There is already a "semi-official" https://hub.docker.com/r/druidio/ that @xvrl set up: https://groups.google.com/d/topic/druid-development/RCLPKrBEMr0/discussion
There was a problem hiding this comment.
Definitely makes sense to me to move this to druidio on docker hub if that repo is made "official" instead of "semi-official" (probably just meaning more druid people should have push access).
There was a problem hiding this comment.
I meant for it to become the official one, @jon-wei is the only one that gave me his login. Maybe once I have all the PMC members in there, it can be christened as the official one? @gianm @fjy @himanshug @drcrallen @cheddar @nishantmonu51
There was a problem hiding this comment.
@xvrl that sounds good to me; my docker hub id is "gianm"
That's not really what happened; in reality what happened is that ZK 3.4.6 was removed from the apache download mirror we were using today. Only the latest ZK 3.4.10 is still there. I'm not sure why this happened, but it didn't seem to hurt to upgrade for the ITs, so I did it. |
|
I mean, it's nice not to forget to change the version in IT, when e. g. in pom.xml it's updated to 3.4.11. Or I didn't understand you? |
|
@leventov Ah, I misunderstood what you meant by "need". I thought you meant it was required for the test to pass. I was just saying it's not. But I guess you just meant it would be nice to upgrade them together, so I will add a comment about that. |
|
LGTM , integration test build had passed ... AnnouncerTest had failed, restarted that. |
* IT: Switch to OpenJDK8 base image. Also split the Docker image into a base image and a child image, and build the base image ahead of time for efficiency's sake. Also upgrade ZK to 3.4.10. * Additional comments about ZK upgrades.
5 participants
Also split the Docker image into a base image and a child image, and
build the base image ahead of time for efficiency's sake. Also upgrade
ZK to 3.4.10 due to missing 3.4.6 downloads on the mirror as seen here:
https://travis-ci.org/druid-io/druid/jobs/299289856