Authorize spec history instead of current specs for supervisor history API#5501
Merged
gianm merged 1 commit intoapache:masterfrom Mar 16, 2018
Merged
Authorize spec history instead of current specs for supervisor history API#5501gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
…r supervisor history API
Contributor
|
The CI failure was #5502, which doesn't seem related to this patch. I restarted the tests. |
gianm
approved these changes
Mar 16, 2018
| } | ||
|
|
||
| @Override | ||
| public int hashCode() |
Contributor
There was a problem hiding this comment.
I usually use the "java.util.Objects (Java 7+)" template for equals/hashCode in IntelliJ; it is more concise. No need to change this but just an FYI for the future.
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Mar 16, 2018
…r supervisor history API (apache#5501)
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Mar 16, 2018
…r supervisor history API (apache#5501)
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Apr 9, 2018
…r supervisor history API (apache#5501)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auth checks on the
/historyand/{id}/historyendpoints in the SupervisorResource are incorrect, they filter based on the current specs of supervisors, instead of filtering the lists of spec history.This PR fixes the checks so that they filter the spec history properly.