Fix supervisor tombstone auth handling#5504
Merged
jon-wei merged 1 commit intoapache:masterfrom Mar 19, 2018
Merged
Conversation
Contributor
|
👍 |
jihoonson
approved these changes
Mar 19, 2018
jon-wei
added a commit
to implydata/druid-public
that referenced
this pull request
Mar 19, 2018
jon-wei
added a commit
to implydata/druid-public
that referenced
this pull request
Mar 19, 2018
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Apr 10, 2018
fjy
pushed a commit
that referenced
this pull request
Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5501 resulted in "tombstone" NoopSupervisorSpecs being filtered out of the spec histories.
This PR adjusts NoopSupervisorSpecs so that they record the datasource list of the previous running spec, for authorization purposes.
NoopSupervisorSpecs created before this change will have a null datasource list and will be visible to all users, for backwards compatibility.