Skip to content

[Backport] Fix metrics for inserting segments#5759

Merged
fjy merged 2 commits intoapache:0.12.1from
jihoonson:backport-5749
May 10, 2018
Merged

[Backport] Fix metrics for inserting segments#5759
fjy merged 2 commits intoapache:0.12.1from
jihoonson:backport-5749

Conversation

@jihoonson
Copy link
Copy Markdown
Contributor

@jihoonson jihoonson commented May 8, 2018 •
edited
Loading

Backport of #5749 to 0.12.1.

This change is Reviewable

@jihoonson jihoonson added this to the 0.12.1 milestone May 8, 2018
@gianm
Copy link
Copy Markdown
Contributor

gianm commented May 8, 2018

@jihoonson the Travis error seems related,

[ERROR] /home/travis/build/druid-io/druid/indexing-service/src/main/java/io/druid/indexing/common/actions/SegmentTransactionalInsertAction.java:132: '.' has incorrect indentation level 6, expected level should be 8. [Indentation]
[ERROR] /home/travis/build/druid-io/druid/indexing-service/src/main/java/io/druid/indexing/common/actions/SegmentTransactionalInsertAction.java:133: '.' has incorrect indentation level 6, expected level should be 8. [Indentation]
Audit done.

@jihoonson
Copy link
Copy Markdown
Contributor Author

jihoonson commented May 8, 2018

@gianm thanks. Fixed.

@jihoonson jihoonson closed this May 9, 2018
@jihoonson jihoonson reopened this May 9, 2018
@jihoonson
Copy link
Copy Markdown
Contributor Author

jihoonson commented May 9, 2018

I don't think the TeamCity failure is related to this change. Would anyone restart it?

@gianm
Copy link
Copy Markdown
Contributor

gianm commented May 9, 2018

@jihoonson I restarted it

@fjy fjy merged commit e0e55ee into apache:0.12.1 May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Backport

Projects

None yet

Milestone

0.12.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jihoonson @gianm @fjy