Fix metrics for inserting segments#5749
Merged
jon-wei merged 2 commits intoapache:masterfrom May 8, 2018
Merged
Conversation
drcrallen
approved these changes
May 8, 2018
sathishsri88
pushed a commit
to sathishs/druid
that referenced
this pull request
May 8, 2018
* Fix metrics for inserting segments * Add a comment
jon-wei
pushed a commit
that referenced
this pull request
May 10, 2018
* Revert "Consider waiting and pending compaction tasks as well as running tasks in DruidCoordinatorSegmentCompactor (#5704)" This reverts commit c7a5939. * Revert "Fix metrics for inserting segments (#5749)" This reverts commit c9d6451. * Revert "Typo fix in historical doc (#5753)" This reverts commit aa23fe6. * Revert "Use a bimap for reverse lookups on injective maps (#5681)" This reverts commit e1277d3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metrics should be collected no matter whether the insertion succeeds or not.
This was introduced in 0.12.0, so I labeled for 0.12.1.
This change is