Consider waiting and pending compaction tasks as well as running tasks in DruidCoordinatorSegmentCompactor#5704
Merged
b-slim merged 3 commits intoapache:masterfrom May 9, 2018
Conversation
…s in DruidCoordinatorSegmentCompactor
Contributor
|
@jihoonson can you please provide more context like what this is improving? Thanks |
Contributor
Author
|
@b-slim updated. |
b-slim
reviewed
May 3, 2018
| // compaction is enabled and numRunningCompactTasks is 0. | ||
| Math.max(1, compactionTaskCapacity); | ||
| LOG.info("Running tasks [%d/%d]", numRunningCompactTasks, compactionTaskCapacity); | ||
| LOG.info("Running tasks [%d/%d]", numNonCompleteCompactionTasks, compactionTaskCapacity); |
Contributor
There was a problem hiding this comment.
can we make this more readable something like Total running and waiting tasks [], Maximum compaction queue capacity []. Thanks
Contributor
Author
There was a problem hiding this comment.
Good point. Fixed.
Contributor
|
👍 left minor comment. |
Contributor
Author
|
@b-slim do you have more comments? |
Contributor
|
nop was waiting if someone else want to review it, i will merge it by end of day if no one look at this. |
Contributor
Author
|
@b-slim thanks. |
jon-wei
pushed a commit
that referenced
this pull request
May 10, 2018
* Revert "Consider waiting and pending compaction tasks as well as running tasks in DruidCoordinatorSegmentCompactor (#5704)" This reverts commit c7a5939. * Revert "Fix metrics for inserting segments (#5749)" This reverts commit c9d6451. * Revert "Typo fix in historical doc (#5753)" This reverts commit aa23fe6. * Revert "Use a bimap for reverse lookups on injective maps (#5681)" This reverts commit e1277d3.
jihoonson
added a commit
to implydata/druid-public
that referenced
this pull request
Jun 11, 2018
…s in DruidCoordinatorSegmentCompactor apache#5704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DruidCoordinatorSegmentCompactorcurrently computes the available number of task slots for compaction based on the number of running compaction tasks, i.e., total number of task slots - number of running compaction tasks. This PR is to consider pending and waiting compaction tasks as well to compute more accurate available compaction task slots.This change is