Revert "Use a bimap for reverse lookups on injective maps"#5764
Merged
jon-wei merged 4 commits intoapache:masterfrom May 10, 2018
dylwylie:revert-5681-lookup-bimap
Merged
Revert "Use a bimap for reverse lookups on injective maps"#5764jon-wei merged 4 commits intoapache:masterfrom dylwylie:revert-5681-lookup-bimap
jon-wei merged 4 commits intoapache:masterfrom
dylwylie:revert-5681-lookup-bimap
Conversation
Contributor
Author
|
Reverting this, the following code passes in an offHeap backed map from MapDb, so we'd inadvertently be copying all of its data on heap when creating the BiMap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5681