Merged
Conversation
jihoonson
reviewed
Jun 28, 2018
| @Override | ||
| public byte[] getCacheKey() | ||
| { | ||
| return ByteBuffer.allocate(1).put(DimFilterUtils.NOOP_CACHE_ID).array(); |
Contributor
There was a problem hiding this comment.
Please remove NOOP_CACHE_ID as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI run for #5711 was completed before #5872 was merged, so it was missing a "getRequiredColumns()" implementation, which breaks master build right now.
This PR also deletes the NoopDimFilter which was not exposed to users and only used in one test with the TrueDimFilter.