add method getRequiredColumns for DimFilter#5872
Merged
jon-wei merged 2 commits intoapache:masterfrom Jun 27, 2018
Merged
Conversation
Contributor
|
@zhangxinyu1 thank you for the patch! Would you check the CI failure? |
zhangxinyu1
force-pushed
the
feature-add-getRequiredColumns-method-to-dimFilter
branch
from
40e5ede to
9a3bf55
Compare
Contributor
Author
|
@jihoonson I have fixed the bug. Could you please take a look at it? |
jon-wei
approved these changes
Jun 27, 2018
himanshug
reviewed
Aug 28, 2018
| /** | ||
| * @return a HashSet that represents all columns' name which the DimFilter required to do filter. | ||
| */ | ||
| HashSet<String> getRequiredColumns(); |
Contributor
There was a problem hiding this comment.
Can we have the return type be Set<String> instead so that single column cases can just return ImmutableSet.of(col) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to get required columns in materialized-view feature, it's better to add a method to DimFilter which returns all required column names.
see issue #5710