Coordinator fix balance to try to move max segments instead of up to max segments#5927
Merged
gianm merged 3 commits intoapache:masterfrom Jul 4, 2018
Merged
Conversation
jihoonson
approved these changes
Jul 4, 2018
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 5, 2018
…max segments (apache#5927) * fix move to try to move max segments instead of "up to" max segments * fix * fix oops
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Jul 7, 2018
…max segments (apache#5927) * fix move to try to move max segments instead of "up to" max segments * fix * fix oops
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Jul 9, 2018
…f up to max segments (apache#5927)" This reverts commit 092fdf6.
Contributor
clintropolis
added a commit
to implydata/druid-public
that referenced
this pull request
Jul 18, 2018
…max segments (apache#5927) * fix move to try to move max segments instead of "up to" max segments * fix * fix oops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to behavior of
CostBalancerStrategy.pickSegmentToMovepotentially returningnullfor a segment to move,DruidCoordinatorBalancermay not attempt to movemaxSegmentsToMoveevery balancer run, also throwing offunmovedtracking and missing out onNo good moves...log messages. Balancer will now always attempt to movemaxSegmentsToMoveensuring thatmoved + unmovedadd up.