[Backport] Coordinator fix balance to try to move max segments instead of up to max segments#5974
Closed
jihoonson wants to merge 1 commit intoapache:0.12.2from
Closed
[Backport] Coordinator fix balance to try to move max segments instead of up to max segments#5974jihoonson wants to merge 1 commit intoapache:0.12.2from
jihoonson wants to merge 1 commit intoapache:0.12.2from
Conversation
…max segments (apache#5927) * fix move to try to move max segments instead of "up to" max segments * fix * fix oops
Contributor
|
oh noes, I don't have privileges to restart specific travis tests anymore |
Contributor
Author
|
@drcrallen thanks for checking. I restarted. It looks that only some committers have been added to the Apache Druid committers of Github. Did you set your Gitbox account? |
Contributor
|
@drcrallen you should be able to if you go through GitBox setup: https://gitbox.apache.org/setup/ |
Contributor
Author
|
I think it would be better to not backport this because it looks not having a huge improvement on segment balancing to be worth to wait for #5981 to be fixed. |
Contributor
|
@jihoonson, that sounds good, let's move #5927 outside of 0.12.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5927 to 0.12.2.