Skip to content

RowBasedKeySerde should use empty dictionary in constructor #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianm merged 1 commit into from
Aug 29, 2018
Merged

RowBasedKeySerde should use empty dictionary in constructor #6256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions processing/src/main/java/io/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,6 @@ static long estimateStringKeySize(@Nullable String key)

private static class RowBasedKeySerde implements Grouper.KeySerde<RowBasedGrouperHelper.RowBasedKey>
{
private static final int DICTIONARY_INITIAL_CAPACITY = 10000;
private static final int UNKNOWN_DICTIONARY_ID = -1;

private final boolean includeTimestamp;
Expand Down Expand Up @@ -958,9 +957,9 @@ private static class RowBasedKeySerde implements Grouper.KeySerde<RowBasedGroupe
this.valueTypes = valueTypes;
this.limitSpec = limitSpec;
this.enableRuntimeDictionaryGeneration = dictionary == null;
this.dictionary = enableRuntimeDictionaryGeneration ? new ArrayList<>(DICTIONARY_INITIAL_CAPACITY) : dictionary;
this.dictionary = enableRuntimeDictionaryGeneration ? new ArrayList<>() : dictionary;
this.reverseDictionary = enableRuntimeDictionaryGeneration ?
new Object2IntOpenHashMap<>(DICTIONARY_INITIAL_CAPACITY) :
new Object2IntOpenHashMap<>() :
new Object2IntOpenHashMap<>(dictionary.size());
this.reverseDictionary.defaultReturnValue(UNKNOWN_DICTIONARY_ID);
this.maxDictionarySize = maxDictionarySize;
Expand Down