RowBasedKeySerde should use empty dictionary in constructor#6256
RowBasedKeySerde should use empty dictionary in constructor#6256gianm merged 1 commit intoapache:masterfrom
Conversation
gianm
left a comment
There was a problem hiding this comment.
LGTM. Could you please add a comment about why the map is starting out empty (avoiding allocating too much when it's not needed)? Otherwise, a future contributor might not realize it.
jihoonson
left a comment
There was a problem hiding this comment.
I've checked more around RowBasedKeySerde and noticed that it's initialized to 10000 no matter whether spilling is enabled or not in ConcurrentGrouper. Also, it's always initialized no matter what the column type is even though it's being used for only string columns. Probably we can optimize this further, but it looks a different issue. This patch looks good to me. Thanks @gaodayue!
|
We should probably backport this to 0.12.3 |
Thank you @gianm . It's a good advice, but the PR is merged. Maybe we can add it in future optimization. |
Fixes #6255