Fix overlord api and console#6686
Merged
clintropolis merged 3 commits intoapache:masterfrom Nov 30, 2018
Merged
Conversation
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
👍 after CI
I suppose the changes to expectAuthorizationTokenCheck wouldn't have helped here anyway since there is no test for shutdownAllTasks, but I think it's probably good to be checking that checked is called where expected 👍
QiuMM
approved these changes
Nov 30, 2018
clintropolis
approved these changes
Nov 30, 2018
clintropolis
pushed a commit
to clintropolis/druid
that referenced
this pull request
Nov 30, 2018
* Fix overlord APIs and console * remove getRunningTasksByDataSource * add missing path to isApplicable
clintropolis
pushed a commit
to implydata/druid-public
that referenced
this pull request
Nov 30, 2018
* Fix overlord APIs and console * remove getRunningTasksByDataSource * add missing path to isApplicable
fjy
pushed a commit
that referenced
this pull request
Nov 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6684.
There're two APIs causing the error of "org.apache.druid.java.util.common.ISE: Request did not have an authorization check performed", i.e.,
/task/{dataSource}/shutdownAllTasksand/dataSources/{dataSource}.For
/task/{dataSource}/shutdownAllTasks, I fixed the bug and changed the path to/datasources/{dataSource}/shutdownAllTaskssince I think it makes more sense.For
/dataSources/{dataSource}, I removed it because the new/tasksAPI can do the same thing. This API was added in #5260 which is tagged 0.13.0, so I think it's fine to remove it.To test overlord APIs, I fixed
OverlordResourceTestto do some real tests. But, authorization check by annotatedResourceFilteris not easy, so I commented out them in the test and opened #6685.I also fixed the
killbutton of overlord console.