remove AbstractResourceFilter.isApplicable because it is not#6691
Merged
asdf2014 merged 2 commits intoapache:masterfrom Dec 1, 2018
Merged
remove AbstractResourceFilter.isApplicable because it is not#6691asdf2014 merged 2 commits intoapache:masterfrom
asdf2014 merged 2 commits intoapache:masterfrom
Conversation
…ts for OverlordResource.doShutdown and OverlordResource.shutdownTasksForDatasource
jihoonson
reviewed
Nov 30, 2018
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
Thanks for raising this and adding missing tests!
| Assert.assertEquals(new TaskStatusResponse("othertask", null), taskStatusResponse2); | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Would you please remove one extra line breakings before/after new tests?
jihoonson
approved these changes
Nov 30, 2018
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
LGTM. Thanks @clintropolis!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractResourceFilter.isApplicablewas added in #2424 but it would appear that it was never wired up to anything. It doesn't appear to be necessary, so I have removed it to reduce confusion and lower maintenance overhead to not require any consumer of anAbstractResourceFilterimplementation to add it's url prefix to the filter in order for it to behave as intended were this code path actually in place.This PR also adds tests for
OverlordResource.doShutdownandOverlordResource.shutdownTasksForDatasourceas a follow up to #6686.