use System.err and System.out to print exit messages on CliPeon#6975
Merged
asdf2014 merged 3 commits intoapache:masterfrom Feb 1, 2019
Merged
use System.err and System.out to print exit messages on CliPeon#6975asdf2014 merged 3 commits intoapache:masterfrom
asdf2014 merged 3 commits intoapache:masterfrom
Conversation
jon-wei
approved these changes
Feb 1, 2019
justinborromeo
pushed a commit
to justinborromeo/incubator-druid
that referenced
this pull request
Feb 2, 2019
…he#6975) * use System.err and System.out to print exit messages on CliPeon * more * not necessarily a stopping error...
Merged
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Feb 5, 2019
…he#6975) * use System.err and System.out to print exit messages on CliPeon * more * not necessarily a stopping error...
clintropolis
added a commit
to implydata/druid-public
that referenced
this pull request
Feb 5, 2019
…he#6975) * use System.err and System.out to print exit messages on CliPeon * more * not necessarily a stopping error...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CliPeonattempts to log stuff after the log module has been stopped, which does not work. This switches these messages to directly useSystem.outandSystem.errso at least the messages go somewhere.End of task if an error occurs after stopping will appear as:
instead of the exception being eaten and nothing printed.
This will make it more obvious why a task might report
SUCCESSin task logs in terms of completion of the indexing job, but show asFAILEDoverall.