Skip to content

use System.err and System.out to print exit messages on CliPeon #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asdf2014 merged 3 commits into from
Feb 1, 2019
Merged

use System.err and System.out to print exit messages on CliPeon #6975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f78b38
use System.err and System.out to print exit messages on CliPeon
clintropolis Feb 1, 2019
c37ac1b
more
clintropolis Feb 1, 2019
c17dede
not necessarily a stopping error...
clintropolis Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions services/src/main/java/org/apache/druid/cli/CliPeon.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import io.airlift.airline.Arguments;
import io.airlift.airline.Command;
import io.airlift.airline.Option;
import io.netty.util.SuppressForbidden;
import org.apache.druid.client.cache.CacheConfig;
import org.apache.druid.client.coordinator.CoordinatorClient;
import org.apache.druid.client.indexing.HttpIndexingServiceClient;
Expand Down Expand Up @@ -345,6 +346,7 @@ public SegmentListerResource getSegmentListerResource(
);
}

@SuppressForbidden(reason = "System#out, System#err")
@Override
public void run()
{
Expand Down Expand Up @@ -375,14 +377,15 @@ public void run()
Runtime.getRuntime().removeShutdownHook(hook);
}
catch (IllegalStateException e) {
log.warn("Cannot remove shutdown hook, already shutting down");
System.err.println("Cannot remove shutdown hook, already shutting down!");
}
}
catch (Throwable t) {
log.error(t, "Error when starting up. Failing.");
System.err.println("Error!");
System.err.println(Throwables.getStackTraceAsString(t));
System.exit(1);
}
log.info("Finished peon task");
System.out.println("Finished peon task");
}
catch (Exception e) {
throw Throwables.propagate(e);
Expand Down