Skip to content

Update LICENSE and NOTICE files#7026

Merged
jon-wei merged 2 commits intoapache:masterfrom
jon-wei:license_notice
Mar 5, 2019
Merged

Update LICENSE and NOTICE files#7026
jon-wei merged 2 commits intoapache:masterfrom
jon-wei:license_notice

Conversation

@jon-wei
Copy link
Copy Markdown
Contributor

@jon-wei jon-wei commented Feb 7, 2019

Updates the LICENSE and NOTICE files in preparation for the next release.

Notes:

  • At one point we included a modified TestNG which was mentioned in our old NOTICE file. However, this was removed in Remove pached TestNG classes #5165, so I have removed references to that in LICENSE.
  • We previously had a dependency on https://github.com/typetools/checker-framework introduced by Double-checked locking bugs #6662. The main project is GPL licensed, but the annotations it provides are MIT licensed. We only use annotations from this project, so this PR changes the dependency to checker-qual (just the annotations).
  • Helper scripts for retrieving dependency info have been added to docs/_bin
  • The LICENSE and NOTICE files are split into source-only and binary distribution versions, with associated packaging changes.
  • Bundled licenses are stored in the licenses/src directory for source-level inclusions, and licenses/bin for binary-only dependencies
  • The binary distribution now includes the README.md file along with the contents of a new LABELS.md file appended, used to hold licensing labels for Category B licenses (http://www.apache.org/legal/resolved.html#what-can-we-maybe-include-in-an-asf-project-category-b).

I am using the information at https://github.com/justinmclean/ApacheWombat as a reference for the process.

@jon-wei jon-wei added this to the 0.14.0 milestone Feb 7, 2019
@jon-wei jon-wei added the WIP label Feb 7, 2019
@jon-wei jon-wei changed the title Update LICENSE and NOTICE files [WIP] Update LICENSE and NOTICE files Feb 7, 2019
@jon-wei
Copy link
Copy Markdown
Contributor Author

jon-wei commented Feb 7, 2019

marking WIP, some of the "licenseFile" entries (pulled from node dependencies in web-console using a script) are not actually license files, will need to update those

will also need to add license for Bootstrap v3.1.1

@clintropolis
Copy link
Copy Markdown
Member

I think the licenses/ folder needs to be excluded from rat check 🙃

@jon-wei jon-wei force-pushed the license_notice branch 4 times, most recently from ead16e1 to 1c59010 Compare February 20, 2019 00:05
@jon-wei jon-wei removed the WIP label Feb 23, 2019
@jon-wei jon-wei changed the title [WIP] Update LICENSE and NOTICE files Update LICENSE and NOTICE files Feb 23, 2019
@jon-wei
Copy link
Copy Markdown
Contributor Author

jon-wei commented Feb 23, 2019

We are still working with Apache Legal to resolve the Blueprint dependency questions, but this PR is ready for review otherwise.

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Feb 28, 2019

It looks like one of the new files needs to be excluded:

[WARNING] Files with unapproved licenses:
  LABELS.md

Also, in light of #7139 the comment #7026 (comment) should be resolved, at least for now.

@jon-wei jon-wei force-pushed the license_notice branch 2 times, most recently from bd87ea4 to da80a2c Compare February 28, 2019 09:23
@jon-wei
Copy link
Copy Markdown
Contributor Author

jon-wei commented Feb 28, 2019

I've updated this to reflect the licenses after the Blueprint downgrade patch

Copy link
Copy Markdown
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach LGTM - after we get this confirmed as the right way to do things during our 0.14 release process, please go back and add documentation for future release managers. Thanks!!

@jon-wei
Copy link
Copy Markdown
Contributor Author

jon-wei commented Mar 5, 2019

@clintropolis @gianm Thanks for the review, I'll update this area with more documentation/automation for future release managers after 0.14.0.

@jon-wei jon-wei merged commit 5486c2a into apache:master Mar 5, 2019
jon-wei added a commit to jon-wei/druid that referenced this pull request Mar 5, 2019
* Update LICENSE and NOTICE files

* Update react-table version
clintropolis pushed a commit that referenced this pull request Mar 5, 2019
* Update LICENSE and NOTICE files

* Update react-table version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants