Skip to content

add license checker to web-console#7028

Merged
fjy merged 4 commits intoapache:masterfrom
clintropolis:web-console-license-checker
Mar 2, 2019
Merged

add license checker to web-console#7028
fjy merged 4 commits intoapache:masterfrom
clintropolis:web-console-license-checker

Conversation

@clintropolis
Copy link
Copy Markdown
Member

@clintropolis clintropolis commented Feb 7, 2019

This PR modifies druid-console to add a 'dev dependency' to a lib called license-checker and adds a check-licenses npm "script" that is run by maven to ensure dependencies are apache license compatible. A file containing all licenses, web-console/licenses.json, is also generate during build for usage with license collection stuff in #7026.

Output during maven execution:

...
[INFO] --- frontend-maven-plugin:1.6:npm (license-check) @ druid-console ---
[INFO] Running 'npm run check-licenses' in /Users/clint/workspace/clintropolis/druid/web-console/target
[INFO] 
[INFO] > web-console@0.14.0 check-licenses /Users/clint/workspace/clintropolis/druid/web-console
[INFO] > license-checker --production --onlyAllow 'Apache-1.1;Apache-2.0;BSD-2-Clause;BSD-3-Clause;MIT;CC0-1.0' --summary
[INFO] 
[INFO] ├─ MIT: 74
[INFO] ├─ BSD-3-Clause: 4
[INFO] ├─ Apache-2.0: 3
[INFO] └─ (GPL-2.0 OR MIT): 1
[INFO] 
[INFO] 
...

@clintropolis clintropolis added this to the 0.14.0 milestone Feb 7, 2019
@clintropolis clintropolis removed the WIP label Feb 15, 2019
@fjy fjy merged commit 050728b into apache:master Mar 2, 2019
jon-wei pushed a commit to jon-wei/druid that referenced this pull request Mar 4, 2019
* add license checker to web-console to ensure npm dependencies are apache license compatible

* add generate licenses file

* update check to remove excludes due to blueprintjs downgrade
fjy pushed a commit that referenced this pull request Mar 5, 2019
* add license checker to web-console to ensure npm dependencies are apache license compatible

* add generate licenses file

* update check to remove excludes due to blueprintjs downgrade
@clintropolis clintropolis deleted the web-console-license-checker branch March 13, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants