Merged
Conversation
…che license compatible
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Mar 4, 2019
* add license checker to web-console to ensure npm dependencies are apache license compatible * add generate licenses file * update check to remove excludes due to blueprintjs downgrade
fjy
pushed a commit
that referenced
this pull request
Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
druid-consoleto add a 'dev dependency' to a lib calledlicense-checkerand adds acheck-licensesnpm "script" that is run by maven to ensure dependencies are apache license compatible. A file containing all licenses,web-console/licenses.json, is also generate during build for usage with license collection stuff in #7026.Output during maven execution: