Fix exception when the scheme is missing in endpointUrl for S3#7129
Merged
fjy merged 2 commits intoapache:masterfrom Feb 25, 2019
Merged
Fix exception when the scheme is missing in endpointUrl for S3#7129fjy merged 2 commits intoapache:masterfrom
fjy merged 2 commits intoapache:masterfrom
Conversation
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Feb 28, 2019
…e#7129) * Fix exception when the scheme is missing in endpointUrl for S3 * add null check
fjy
pushed a commit
that referenced
this pull request
Mar 1, 2019
#7166) * Fix exception when the scheme is missing in endpointUrl for S3 * add null check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URI.create("127.0.0.1:8000").getScheme()throws an exception ofjava.lang.IllegalArgumentException: Illegal character in scheme name at index 0: 127.0.0.1:8000andURI.create("localhost:8000").getScheme()returnslocalhost.The order to look for the protocol is supposed to be:
endpointUrlAWSClientConfig