Skip to content

Added tslint to web console#7280

Merged
fjy merged 4 commits intoapache:masterfrom
implydata:web-console-tslint
Mar 17, 2019
Merged

Added tslint to web console#7280
fjy merged 4 commits intoapache:masterfrom
implydata:web-console-tslint

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

Added tslint to the build to enforce code style and made the existing code comply to the newly enforced code style.

@vogievetsky
Copy link
Copy Markdown
Contributor Author

Note that this PR will naturally conflict with every other web console PR and if another console PR is merged then the tests here will probably fail until this PR is rebased and the tslint rerun with the fix: true option.

@clintropolis
Copy link
Copy Markdown
Member

Note that this PR will naturally conflict with every other web console PR and if another console PR is merged then the tests here will probably fail until this PR is rebased and the tslint rerun with the fix: true option.

Yeah, I suspected that would happen, I will make sure to test master after this is merged to ensure the build still works 👍

@vogievetsky
Copy link
Copy Markdown
Contributor Author

I started this PR by committing the same tslint-file that was not the strictest and a bit out of date (new tslint rules were added since that file was written).
I had a think about it and decided to go over all the rules and make the linter much more strict.
In particular the new linter will ensure a consistent sort order and groping of imports, will also lint the React JSX part, and will make sure there is an Apache license header file.
I have employed the autofixer (which has been a godsend) to make the majority of the changes in the actual diff. Having gone over all the rules I believe this is now sufficiently strict and good to go.

@fjy fjy added this to the 0.15.0 milestone Mar 17, 2019
@fjy fjy merged commit b6b1e61 into apache:master Mar 17, 2019
@vogievetsky vogievetsky deleted the web-console-tslint branch March 18, 2019 01:00
clintropolis pushed a commit to implydata/druid-public that referenced this pull request Apr 3, 2019
* added tslint to web console

* added react linting and made rules stricter

* order imports

* update package-lock
gianm pushed a commit to implydata/druid-public that referenced this pull request Apr 8, 2019
* added tslint to web console

* added react linting and made rules stricter

* order imports

* update package-lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants