Added tslint to web console

web-console/package.json

@@ -70,6 +70,9 @@
     "ts-jest": "^23.10.5",
     "ts-loader": "^5.3.3",
     "ts-node": "^8.0.2",
+    "tslint": "^5.14.0",
+    "tslint-loader": "^3.5.4",
+    "tslint-react": "^3.6.0",
     "typescript": "^3.2.4",
     "webpack": "^4.29.0",
     "webpack-cli": "^3.2.1",

web-console/script/create-sql-function-doc

@@ -21,8 +21,35 @@ writefile='lib/sql-function-doc.ts'
 
 > "$writefile"
 
-echo -e "// This file is auto generated and should not be modified\n" > "$writefile"
-echo -e 'export const SQLFunctionDoc: any[] = [' >> "$writefile"
+cat > "$writefile" <<- EOM
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// This file is auto generated and should not be modified
+
+export interface FunctionDescription {
+  syntax: string;
+  description: string;
+}
+
+/* tslint:disable */
+export const SQLFunctionDoc: FunctionDescription[] = [
+EOM
 
 isFunction=false
 
@@ -39,12 +66,12 @@ while read -r line; do
             description=$(echo $line | grep -o '`|.*.|')
             description=${description//\"/\'}
             description=${description:2:${#description}-4}
-            echo -e "   {" >> "$writefile"
-            echo -e "       syntax: \"$syntax\"," >> "$writefile"
-            echo -e "       description: \"$description\"" >> "$writefile"
-            echo -e "   }," >> "$writefile"
+            echo -e "  {" >> "$writefile"
+            echo -e "    syntax: \"$syntax\"," >> "$writefile"
+            echo -e "    description: \"$description\"" >> "$writefile"
+            echo -e "  }," >> "$writefile"
         fi
     fi
 done < "$readfile"
 
-echo -e ']' >> "$writefile"
+echo -e '];' >> "$writefile"

web-console/src/bootstrap/a-shim-for-react-props.ts

@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Trick blueprint 1.0.1 into accepting React 16 as React 15.
+// This is broken into its own file to make linting and import sorting easy
+// This file "a" to make sure it is imported before console-application in entry.ts
+
+// tslint:disable
+import * as React from 'react';
+(React as any).PropTypes = require('prop-types');

web-console/src/singletons/react-table-defaults.tsx → web-console/src/bootstrap/react-table-defaults.tsx

@@ -16,10 +16,10 @@
  * limitations under the License.
  */
 
-
+import { Button } from "@blueprintjs/core";
 import * as React from 'react';
 import { Filter, ReactTableDefaults } from "react-table";
-import { Button } from "@blueprintjs/core";
+
 import { Loader } from '../components/loader';
 import { countBy, makeTextFilter } from '../utils';
 

web-console/src/components/auto-form.tsx

@@ -16,11 +16,10 @@
  * limitations under the License.
  */
 
-import { resolveSrv } from 'dns';
-import * as React from 'react';
-import axios from 'axios';
 import { InputGroup } from "@blueprintjs/core";
-import { HTMLSelect, FormGroup, NumericInput, TagInput } from "../components/filler";
+import * as React from 'react';
+
+import { FormGroup, HTMLSelect, NumericInput, TagInput } from "../components/filler";
 
 interface Field {
   name: string;
@@ -31,8 +30,8 @@ interface Field {
 
 export interface AutoFormProps<T> extends React.Props<any> {
   fields: Field[];
-  model: T | null,
-  onChange: (newValue: T) => void
+  model: T | null;
+  onChange: (newValue: T) => void;
 }
 
 export interface AutoFormState<T> {
@@ -48,7 +47,7 @@ export class AutoForm<T> extends React.Component<AutoFormProps<T>, AutoFormState
   constructor(props: AutoFormProps<T>) {
     super(props);
     this.state = {
-    }
+    };
   }
 
   private renderNumberInput(field: Field): JSX.Element {
@@ -97,7 +96,7 @@ export class AutoForm<T> extends React.Component<AutoFormProps<T>, AutoFormState
     >
       <option value="True">True</option>
       <option value="False">False</option>
-    </HTMLSelect>
+    </HTMLSelect>;
   }
 
   private renderStringArrayInput(field: Field): JSX.Element {
@@ -127,14 +126,14 @@ export class AutoForm<T> extends React.Component<AutoFormProps<T>, AutoFormState
     const label = field.label || AutoForm.makeLabelName(field.name);
     return <FormGroup label={label} key={field.name}>
       {this.renderFieldInput(field)}
-    </FormGroup>
+    </FormGroup>;
   }
 
   render() {
     const { fields, model } = this.props;
 
     return <div className="auto-form">
       {model && fields.map(field => this.renderField(field))}
-    </div>
+    </div>;
   }
 }

web-console/src/components/filler.tsx

@@ -17,10 +17,10 @@
  */
 
 import { Button } from '@blueprintjs/core';
-import * as React from 'react';
 import classNames from 'classnames';
-import './filler.scss';
+import * as React from 'react';
 
+import './filler.scss';
 
 export const IconNames = {
   ERROR: "error" as "error",
@@ -103,16 +103,15 @@ export class FormGroup extends React.Component<{ className?: string, label?: str
   render() {
     const { className, label, children } = this.props;
     return <div className={classNames("form-group", className)}>
-      { label ? <Label>{label}</Label> : null }
+      {label ? <Label>{label}</Label> : null}
       {children}
     </div>;
   }
 }
 
-
 export const Alignment = {
   LEFT: "left" as "left",
-  RIGHT: "right" as "right",
+  RIGHT: "right" as "right"
 };
 export type Alignment = typeof Alignment[keyof typeof Alignment];
 
@@ -166,28 +165,28 @@ export interface NumericInputProps {
   min?: number;
   max?: number;
   stepSize?: number;
-  majorStepSize?: number
+  majorStepSize?: number;
 }
 
 export class NumericInput extends React.Component<NumericInputProps, { stringValue: string }> {
 
   static defaultProps = {
     stepSize: 1,
     majorStepSize: 10
-  }
+  };
 
   constructor(props: NumericInputProps) {
     super(props);
     this.state = {
       stringValue: typeof props.value === 'number' ? String(props.value) : ''
-    }
+    };
   }
 
   private constrain(n: number): number {
     const { min, max } = this.props;
     if (typeof min === 'number') n = Math.max(n, min);
     if (typeof max === 'number') n = Math.min(n, max);
-    return n
+    return n;
   }
 
   private handleChange = (e: any) => {
@@ -236,13 +235,13 @@ export class TagInput extends React.Component<TagInputProps, { stringValue: stri
     super(props);
     this.state = {
       stringValue: Array.isArray(props.values) ? props.values.join(', ') : ''
-    }
+    };
   }
 
   handleChange = (e: any) => {
-    let stringValue = e.target.value;
-    let newValues = stringValue.split(',').map((v: string) => v.trim());
-    let newValuesFiltered = newValues.filter(Boolean);
+    const stringValue = e.target.value;
+    const newValues = stringValue.split(',').map((v: string) => v.trim());
+    const newValuesFiltered = newValues.filter(Boolean);
     this.setState({
       stringValue: newValues.length === newValuesFiltered.length ? newValues.join(', ') : stringValue
     });