Migrate the web console back to Blueprint v3#7398
Merged
fjy merged 3 commits intoapache:masterfrom Apr 2, 2019
Merged
Conversation
clintropolis
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 3, 2019
* migrate back to Blueprint v3 * rename filler file * fix missing icon
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 8, 2019
* migrate back to Blueprint v3 * rename filler file * fix missing icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The saga concludes! 🎆
First the web console was written in BP3 then it was discovered that the license on BP3 was non-standard so we hastily migrated the console to use BP1.0.1 which had a vanilla Apache 2.0 license. Now Palantir and the Blueprint team has agreed to change the license back to vanilla Apache 2.0.
This PR upgrades Blueprint to version 3.15.0 (or above) which is Apache 2.0 licensed.
This PR effectively undoes the work in #7139
Result: the web console is a little more beautiful and a lot less hacky with easy to find current docs for its code UI framework.