Conversation
| MIT License | ||
|
|
||
| Copyright (c) 2012-2018 Faisal Salman <<f@faisalman.com>> | ||
| Copyright (c) |
There was a problem hiding this comment.
This looks wrong. There should be a year and copyright holder.
There was a problem hiding this comment.
Hmm, I thought I removed this file. This is not needed since ua-parser-js is not bundled. Will remove.
| This product bundles diff-match-patch version 1.0.4. | ||
|
|
||
| This product bundles @blueprintjs/core version 1.0.1. | ||
| This product bundles @blueprintjs/core and @blueprintjs/icons of version 3.15.0. |
There was a problem hiding this comment.
Are these dependency lists and version numbers being updated automatically or are you doing it by hand? If it's by hand, let's think about how to automate it, since this seems like a lot of work!!
By the way, I think to make release managers' lives easier, anything that can't feasibly automated we should try to get done in the PR that makes the original changes. So these changes could have been done in #7398.
There was a problem hiding this comment.
Some part of the process is automated (docs/_bin/npm-license-helper.py and docs/_bin/web-console-dep-lister.py), but it still needs quite a lot of manual work. I'm thinking something to automate most of the part. Will raise an issue (or maybe proposal?) soon.
| The following dependency names are NPM package names (https://www.npmjs.com). | ||
|
|
||
| This product bundles @babel/runtime version 7.3.4, copyright Sebastian McKenzie and other contributors, | ||
| This product bundles @babel/runtime version 7.4.3, copyright Sebastian McKenzie, |
There was a problem hiding this comment.
Where's 7.4.3 from? I see it in web-console/package-lock.json as version 7.4.5.
There was a problem hiding this comment.
Dang, 7.4.3 is used in 0.15.0. Didn't notice this version was bumped up again.
Looks like this PR needs to be adjusted to master. I will close this and raise another PR for 0.15.0.
2 participants
No description provided.