Fix too many dentry cache slab objs#7508.#7509
Fix too many dentry cache slab objs#7508.#7509fjy merged 1 commit intoapache:masterfrom kaka11chen:fix-too-many-dentry-cache-slab-objs#7508
Conversation
There was a problem hiding this comment.
size must actually check the object, and depending on the collection, may have to traverse or do other special record keeping operations. Some collections can optimize this and others cannot. isEmpty() should be used when simply checking for emptyness.
There was a problem hiding this comment.
Good catch. Thanks.
|
There's another hidden FS bug here: If two methods call this, and the first one that finishes causes the JVM to be shut down, then the other one may never finish and actually do the delete. It is at the author's discretion if they want to keep the scope of this PR to just #7508 or to fix up `LimitedTemporaryStorage::close`` in general If the author wishes to keep the scope limited, then I'm 👍 once the |
|
@drcrallen I have changed the source code with checking a flag |
Fix #7508.