Skip to content

Fix too many dentry cache slab objs#7508. #7509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjy merged 1 commit into from
Apr 20, 2019
Merged

Fix too many dentry cache slab objs#7508. #7509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...g/src/main/java/org/apache/druid/query/groupby/epinephelinae/LimitedTemporaryStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ public class LimitedTemporaryStorage implements Closeable

private volatile boolean closed = false;

private boolean createdStorageDirectory = false;

public LimitedTemporaryStorage(File storageDirectory, long maxBytesUsed)
{
this.storageDirectory = storageDirectory;
Expand Down Expand Up @@ -81,6 +83,9 @@ public LimitedOutputStream createFile() throws IOException
}

FileUtils.forceMkdir(storageDirectory);
if (!createdStorageDirectory) {
createdStorageDirectory = true;
}

final File theFile = new File(storageDirectory, StringUtils.format("%08d.tmp", files.size()));
final EnumSet<StandardOpenOption> openOptions = EnumSet.of(
Expand Down Expand Up @@ -126,7 +131,7 @@ public void close()
delete(file);
}
files.clear();
if (storageDirectory.exists() && !storageDirectory.delete()) {
if (createdStorageDirectory && storageDirectory.exists() && !storageDirectory.delete()) {
log.warn("Cannot delete storageDirectory: %s", storageDirectory);
}
}
Expand Down