fix issue with theta sketch in druid-datasketches extension#7619
Merged
clintropolis merged 2 commits intoapache:masterfrom May 10, 2019
Merged
fix issue with theta sketch in druid-datasketches extension#7619clintropolis merged 2 commits intoapache:masterfrom
clintropolis merged 2 commits intoapache:masterfrom
Conversation
gianm
approved these changes
May 9, 2019
Contributor
|
Should we add a unit test? |
Contributor
Author
|
There is no change in Druid code. And we added a test in the sketches-core code. |
Contributor
Author
|
I guess the artifacts did not propagate yet. I see them here: |
Contributor
|
Ok. Will restart CI after a few mins. |
Member
|
Hmm, the failure is perhaps no longer related to missing artifacts: at https://travis-ci.org/apache/incubator-druid/jobs/530049926#L3162 Doing a quick search, this library is licensed as |
clintropolis
approved these changes
May 9, 2019
clintropolis
pushed a commit
that referenced
this pull request
May 10, 2019
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
May 10, 2019
* fix issue apache#7607 * exclude com.google.code.findbugs:annotations
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
May 11, 2019
* fix issue apache#7607 * exclude com.google.code.findbugs:annotations
Merged
jihoonson
added a commit
to implydata/druid-public
that referenced
this pull request
Jun 4, 2019
* fix issue apache#7607 * exclude com.google.code.findbugs:annotations
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 26, 2019
* fix issue apache#7607 * exclude com.google.code.findbugs:annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7607