Skip to content

fix issue with theta sketch in druid-datasketches extension#7619

Merged
clintropolis merged 2 commits intoapache:masterfrom
AlexanderSaydakov:datasketches_0_13_3
May 10, 2019
Merged

fix issue with theta sketch in druid-datasketches extension#7619
clintropolis merged 2 commits intoapache:masterfrom
AlexanderSaydakov:datasketches_0_13_3

Conversation

@AlexanderSaydakov
Copy link
Copy Markdown
Contributor

@AlexanderSaydakov AlexanderSaydakov commented May 9, 2019

Fixes #7607

@jihoonson
Copy link
Copy Markdown
Contributor

Should we add a unit test?

@AlexanderSaydakov
Copy link
Copy Markdown
Contributor Author

There is no change in Druid code. And we added a test in the sketches-core code.

@AlexanderSaydakov
Copy link
Copy Markdown
Contributor Author

I guess the artifacts did not propagate yet. I see them here:
https://repo1.maven.org/maven2/com/yahoo/datasketches/sketches-core/0.13.3/

@jihoonson
Copy link
Copy Markdown
Contributor

Ok. Will restart CI after a few mins.

@clintropolis
Copy link
Copy Markdown
Member

Hmm, the failure is perhaps no longer related to missing artifacts:

[WARNING] Rule 1: org.apache.maven.plugins.enforcer.BannedDependencies failed with message:
Found Banned Dependency: com.google.code.findbugs:annotations:jar:3.0.0
Use 'mvn dependency:tree' to locate the source of the banned dependencies.

at https://travis-ci.org/apache/incubator-druid/jobs/530049926#L3162

Doing a quick search, this library is licensed as lgpl which is perhaps the reason for this issue? Is this a new dependency between 0.13.1 and 0.13.3? I wonder if it can be safely excluded from the datasketches extension pom?

               <exclusions>
                    <exclusion>
                        <groupId>com.google.code.findbugs</groupId>
                        <artifactId>annotations</artifactId>
                    </exclusion>
                </exclusions>

@clintropolis clintropolis merged commit 59f9ff3 into apache:master May 10, 2019
@clintropolis clintropolis changed the title fix issue #7607 fix issue with theta sketch in druid-datasketches extension May 10, 2019
@clintropolis clintropolis added this to the 0.14.2 milestone May 10, 2019
clintropolis pushed a commit that referenced this pull request May 10, 2019
* fix issue #7607

* exclude com.google.code.findbugs:annotations
gianm pushed a commit to implydata/druid-public that referenced this pull request May 10, 2019
* fix issue apache#7607

* exclude com.google.code.findbugs:annotations
jihoonson pushed a commit to jihoonson/druid that referenced this pull request May 11, 2019
* fix issue apache#7607

* exclude com.google.code.findbugs:annotations
clintropolis pushed a commit that referenced this pull request May 11, 2019
* fix issue #7607

* exclude com.google.code.findbugs:annotations
jihoonson added a commit to implydata/druid-public that referenced this pull request Jun 4, 2019
* fix issue apache#7607

* exclude com.google.code.findbugs:annotations
jihoonson pushed a commit to implydata/druid-public that referenced this pull request Jun 26, 2019
* fix issue apache#7607

* exclude com.google.code.findbugs:annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

thetaSketch(with sketches-core-0.13.1) in groupBy always return value no more than 16384

4 participants