Merged
Conversation
Member
gianm
approved these changes
Jun 6, 2019
Member
|
It would appear that this path must be used at least some of the time: related https://groups.google.com/forum/?pli=1#!topic/druid-user/qCBG7E_zR1c |
Contributor
|
Since the sketches-core version was changed, the LICENSE.BINARY file should have updated in this PR accordingly. This will be automatically checked after #7998. |
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 3, 2019
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 3, 2019
clintropolis
pushed a commit
that referenced
this pull request
Jul 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the sketches-core release notes:
"0.13.4 May 14, 2019: Fix Theta Direct Union Bug, alternate path.
It turns out there were two different code paths that would reveal the Direct Union Bug. This fixes the alternate, but seldom used path, which wasn't caught in the previous release."
I am not sure this code path is used in Druid. So this update may or may not be of significance.
By the way, did anyone verify that the previous update to 0.13.3 really fixed the Theta sketch regression (#7619)?