Fix broken links in docs, add broken link checker.#7658
Merged
fjy merged 1 commit intoapache:masterfrom May 15, 2019
Merged
Conversation
Also adds back insert-segment-to-db.md with some docs about why and when it was removed (in apache#6911).
|
|
||
| if [ -n "$opt_docs" ] ; then | ||
| # Check for broken links | ||
| "$src/docs/_bin/broken-link-check.py" "$src/docs/content" "$src/docs/_redirects.json" |
Member
There was a problem hiding this comment.
As far as I could tell, this script doesn't modify anything and just prints out the broken links/redirects, what is the purpose of calling it here? Should we be catching the exit code and have it cause a failure of some sort if it has non-zero exit code?
Contributor
Author
There was a problem hiding this comment.
The bash script is running with mode -e so if any subcommand exits nonzero, it will automatically stop.
Member
There was a problem hiding this comment.
Oops! I see that now, my bad 👍
clintropolis
approved these changes
May 15, 2019
| ## Home | ||
|
|
||
| The home view provide a high level overview of the cluster. Each card is clickable and links to the appropriate view. The legacy menu allows you to go to the [legacy coordinator and overlord consoles](./management-uis#legacy-consoles) should you need them. | ||
| The home view provide a high level overview of the cluster. Each card is clickable and links to the appropriate view. The legacy menu allows you to go to the [legacy coordinator and overlord consoles](./management-uis.html#legacy-consoles) should you need them. |
Member
There was a problem hiding this comment.
nit: this isn't your fault, but 'The home view provides ...'
Suggested change
| The home view provide a high level overview of the cluster. Each card is clickable and links to the appropriate view. The legacy menu allows you to go to the [legacy coordinator and overlord consoles](./management-uis.html#legacy-consoles) should you need them. | |
| The home view provides a high level overview of the cluster. Each card is clickable and links to the appropriate view. The legacy menu allows you to go to the [legacy coordinator and overlord consoles](./management-uis.html#legacy-consoles) should you need them. |
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
May 17, 2019
Also adds back insert-segment-to-db.md with some docs about why and when it was removed (in apache#6911).
fjy
pushed a commit
that referenced
this pull request
May 17, 2019
Merged
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 4, 2019
…che#7689) Also adds back insert-segment-to-db.md with some docs about why and when it was removed (in apache#6911).
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 26, 2019
Also adds back insert-segment-to-db.md with some docs about why and when it was removed (in apache#6911).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds back insert-segment-to-db.md with some docs about why and
when it was removed (in #6911).
Some of these changes should be backported to 0.15.0.